[PATCH 02/13] gnu: Add go-github-com-chyzer-test

  • Done
  • quality assurance status badge
Details
4 participants
  • Fries
  • Maxim Cournoyer
  • (
  • Sharlatan Hellseher
Owner
unassigned
Submitted by
Fries
Severity
normal
Merged with
F
F
Fries wrote on 5 Aug 2023 09:00
(address . guix-patches@gnu.org)(name . Fries)(address . fries1234@protonmail.com)
2d73f9922ae784fa47cb820b73517262ae08f52f.1691218710.git.fries1234@protonmail.com
* gnu/packages/golang.scm (go-github-com-chyzer-test): New variable.
---
gnu/packages/golang.scm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)

Toggle diff (39 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d99f76dc7d..ef82f0aa1b 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -2113,6 +2113,32 @@ (define-public go-github-com-dhowett-go-plist
types.")
(license license:giftware))))
+(define-public go-github-com-chzyer-test
+ (package
+ (name "go-github-com-chzyer-test")
+ (version "1.0.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/chzyer/test")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1axdlcnx2qjsn5wsr2pr1m0w0a8k4nk5kkrngh742fgh81vzzy8s"))))
+ (build-system go-build-system)
+ (arguments
+ '(#:import-path "github.com/chzyer/test"
+ #:phases
+ ;; Tests relating to a in-memory disk fail due to a Segfault.
+ (modify-phases %standard-phases
+ (delete 'check))))
+ (propagated-inputs `(("go-github-com-chzyer-logex" ,go-github-com-chzyer-logex)))
+ (home-page "https://github.com/chzyer/test")
+ (synopsis "Testing")
+ (description "Testing library.")
+ (license license:expat)))
+
(define-public go-github-com-chzyer-logex
(package
(name "go-github-com-chzyer-logex")
--
2.41.0
(
(
( wrote on 5 Aug 2023 11:14
(name . Fries)(address . fries1234@protonmail.com)
87tttdrgt8.fsf@disroot.org
Fries via Guix-patches via <guix-patches@gnu.org> writes:
Toggle quote (7 lines)
> + (arguments
> + '(#:import-path "github.com/chzyer/test"
> + #:phases
> + ;; Tests relating to a in-memory disk fail due to a Segfault.
> + (modify-phases %standard-phases
> + (delete 'check))))

Same as before: use LIST, #~, and #:TESTS?.

Toggle quote (2 lines)
> + (propagated-inputs `(("go-github-com-chzyer-logex" ,go-github-com-chzyer-logex)))

Inputs are now written like this:

(propagated-inputs
(list go-github-com-chzyer-logex))

Toggle quote (3 lines)
> + (synopsis "Testing")
> + (description "Testing library.")

Please provide a more thorough synopsis and description.

-- (
F
F
Fries wrote on 5 Aug 2023 11:30
Merge bugs
(address . control@debbugs.gnu.org)
6131230.DvuYhMxLoT@pc
merge 65075 65072 65076 65073 65078 65077 65079 65082 65080 65081 65084 65085 65083 65074
# accidently sent my patch series to the mailing list instead the cover letters bug
quit
F
F
Fries wrote on 6 Aug 2023 01:13
More cleanly merge bugs
(address . control@debbugs.gnu.org)
5713201.DvuYhMxLoT@pc
unmerge 65072
unmerge 65073
unmerge 65075
unmerge 65076
unmerge 65077
unmerge 65078
unmerge 65079
unmerge 65080
unmerge 65081
unmerge 65082
unmerge 65083
unmerge 65084
unmerge 65085
unmerge 65074
merge 65075 65074
merge 65072 65074
merge 65076 65074
merge 65073 65074
merge 65078 65074
merge 65077 65074
merge 65079 65074
merge 65082 65074
merge 65080 65074
merge 65081 65074
merge 65084 65074
merge 65085 65074
merge 65083 65074
# try to merge all the bugs with just 65074 instead of merging with all of themselves
stop
M
M
Maxim Cournoyer wrote on 1 Sep 2023 14:08
Re: bug#65085: [PATCH 12/13] gnu: Add go-github-com-json-iterator-go
(name . Fries)(address . fries1234@protonmail.com)
87wmxa3xl5.fsf_-_@gmail.com
tags 65072 + moreinfo
quit

Hi Fries,

Thank you for your contribution.

Fries <fries1234@protonmail.com> writes:

Toggle quote (34 lines)
> * gnu/packages/golang.scm (go-github-com-chyzer-test): New variable.
> ---
> gnu/packages/golang.scm | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index d99f76dc7d..ef82f0aa1b 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -2113,6 +2113,32 @@ (define-public go-github-com-dhowett-go-plist
> types.")
> (license license:giftware))))
>
> +(define-public go-github-com-chzyer-test
> + (package
> + (name "go-github-com-chzyer-test")
> + (version "1.0.0")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/chzyer/test")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1axdlcnx2qjsn5wsr2pr1m0w0a8k4nk5kkrngh742fgh81vzzy8s"))))
> + (build-system go-build-system)
> + (arguments
> + '(#:import-path "github.com/chzyer/test"
> + #:phases
> + ;; Tests relating to a in-memory disk fail due to a Segfault.
> + (modify-phases %standard-phases
> + (delete 'check))))

This should be minimally investigated, and ideally an issue created on
upstream issue tracker and an URL added next to the comment to track its
resolution, e.g:

;; Tests relating to a in-memory disk fail due to a segfault (see:
;; $URL).

Also taking the comments from parens into account, could you please send
a v2 to this same issue (65072@debbugs.gnu.org) ?

--
Thanks,
Maxim
S
S
Sharlatan Hellseher wrote on 6 Apr 17:52 +0200
[PATCH 02/13] gnu: Add go-github-com-chyzer-test
(address . 65072-done@debbugs.gnu.org)
87ttkemqtk.fsf@gmail.com
Pushed as c28b319640..cf4f87986a to master by closing

--
Oleg
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmYRb7cACgkQdtcnv/Ys
0rXIrw/+JfMVWlX03VzBJc5yYwfOjdqLToZan/CWLW7zgg3hmLGqn/LibrAMVGmr
VxU9nXBXT0CiXIFKSRmVhX/QM5F5Lg35nX92UmjjoK+tkv1kYWho3yqk+O5mEftV
VmA+1y6hXQz7NH6LVFQbiIv0WgAZV4k3537hoDIO+LU/quG8HzqfuPYX4i5fY+fy
7PPyQa0opbOIXLpK84W8laHnsGPXSxGecIKWEG6vMCpng8SJts0wMZZoj3I6xp6i
aG13SMs7OCzzr/k32KtrzEjdo8HWKZuJPNQhgJnx5DzQtLPJ1T1rmjb7m5FxLtKK
VI0ipqNlWo0s4HLE7KOH+/bm1rFOrTbq3Q4PClzIxLZDBRZuF4e4Yxi0s5RO1vdH
zYus91XFjc4132i1vk4bG66ZgctHuA/V/3XRv9J8ZYimT3rg0htBK7mMqjmqR4mo
48kei7r0CF0/KbtD7HXvNjOVi14Y6IsCaRgk+xpNdr7k5MwY+29IoRYpdw/Bjvwz
NuqB4eYixfVOJuGQmkdXAIDWAOHyJthef+cBNZwY01Npq15JW2Nil5k8b6zn6lGe
TCq5sYzpBJaHYhgg6IQXAdsRIxkrye38zKkAKsVLUKSIvdTllDHj8lUYjijbNk5B
NlYNpmKw5fyVlZvFyubl9jQQX3wrIDPYz+5TG0Ts5pjCvvLKlGo=
=QyBb
-----END PGP SIGNATURE-----

Closed
S
S
Sharlatan Hellseher wrote on 6 Apr 17:53 +0200
(address . 65072-done@debbugs.gnu.org)
87r0fimqs3.fsf@gmail.com
Pushed as c28b319640..cf4f87986a to master by closing

--
Oleg
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmYRb+wACgkQdtcnv/Ys
0rXhgQ/8CVYijZF2/dDznpYg85RH0dIL3AWTwXDtTOwOHAE2FnZ5TaqnlNrIOucf
WwSA227HaehiTgpQboQuyEnE8c+0G+LiLLnIntxw+7k5cuIBSsGuMCWLOa7I6Gmz
ZdyWvBKtoWzqULkVu2xTpPiH4/BHtpRt3CKeXhNvkz5oM2BPvyshYE4AjUzessxo
+brAXMNUvUF8ICagMSQoNRUX7mZVosrPA7/x5LDrM5no0c87wmTRIqxOSu/cEjrX
KR1HpNGR0yHeXPr1lkGKK7VtpzvNPc7QAXjBI8naOIRMd3YycmROqHMDXqHG/lXa
VHht8YK1OGSY2xhE8eVFvEjlIZFADljDcSbEtqftmM06/rQ+q4AvqcKyZ0IZsR7f
4AQmTHdK6VAzXyeOy0leHSOFudRk7DB+T7xcR0oK7P6ZvfjTxtXgJSBbz1dhKav/
PXp2xHCc1jhYITOEKDI+Vj0Luhii02I3dOzwIIDHvlIeA/gr2pPkJFbBVlIsRZjn
nns94ngchzAAxO7aR7VS8idTPit6pcG2VnUwogSOFfleCwDvAX+NHPVxBmbK0+wh
l0X/vULYIFDMybc3cQhTHHssMXqRpmJFL9rBdhNXd0S1yJq38LULBovVh83Ub39p
G02udVqtQzvPBwULRJf8DcOvYH7gdrNbQXeDPVPn5btloelPBNg=
=X/T4
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 65072@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 65072
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch