[PATCH] gnu: Add nfs4-acl-tools

Done

Details

3 participants

Lars-Dominik Braun
Marius Bakke
Michael Rohleder

Owner: unassigned

Submitted by: Lars-Dominik Braun

Severity: normal

Lars-Dominik Braun wrote on 10 Jul 2020 11:21

Recipients:(address . guix-patches@gnu.org)

Message-ID:20200710092101.GA22947@zpidnp36

Attachment: file

Marius Bakke wrote on 25 Jul 2020 17:20

Recipients:

Message-ID:87blk3vcyn.fsf@gnu.org

Hello!

Sorry for the late reply...

The patch mostly LGTM, but no longer applies. Can you rebase it on

current master? Meanwhile, a few comments:

Lars-Dominik Braun <ldb@leibniz-psychology.org> writes:

Toggle quote (4 lines)

> * gnu/packages/acl.scm (nfs4-acl-tools): New variable.

> * gnu/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch: New file.

> * gnu/local.mk: Add it.

[...]

Toggle quote (3 lines)

> + (synopsis "This package contains commandline ACL utilities for the Linux

> +NFSv4 client")

Just "Command line ACL utilities for NFS"

Toggle quote (3 lines)

> + (description "Provides the commandline utilities nfs4_setfacl and

> +nfs4_getfacl, which are similar to their POSIX equivalents.")

Descriptions OTOH should be complete sentences, something like:

"This package provides the command line utilities

@command{nfs4_setfacl} and @command{nfs4_getfacl} [...]".

Lars-Dominik Braun wrote on 27 Jul 2020 09:11

Recipients:(name . Marius Bakke)(address . marius@gnu.org)(address . 42306@debbugs.gnu.org)

Message-ID:20200727071139.GB3225@zpidnp36

Hey Marius,

Toggle quote (1 lines)

> Sorry for the late reply...

no problem.

Toggle quote (2 lines)

> The patch mostly LGTM, but no longer applies. Can you rebase it on

> current master? Meanwhile, a few comments:

Sure, see attached patch, which (hopefully) also improves the description.

I noticed linting fails with a pattern matching error, because git:// protocol

URI’s are not supported. The second patch fixes it, but I’m not sure that’s a

“proper” solution.

Cheers,

Lars

Attachment: 0001-gnu-Add-nfs4-acl-tools.patch

From 5c9dddd0d4b54ca73f4fe4ebac37789bde0e54ce Mon Sep 17 00:00:00 2001
From: Lars-Dominik Braun <ldb@leibniz-psychology.org>
Date: Mon, 27 Jul 2020 09:09:24 +0200
Subject: [PATCH 2/2] =?UTF-8?q?guix:=20lint:=20Ignore=20unsupported=20sour?=
 =?UTF-8?q?ce=20URL=E2=80=99s.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* guix/lint.scm (check-source): Add match case for #f.
---
 guix/lint.scm | 3 +++
 1 file changed, 3 insertions(+)

Toggle diff (16 lines)diff --git a/guix/lint.scm b/guix/lint.scm
index 8a55f3e744..395630aa1c 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -794,6 +794,9 @@ descriptions maintained upstream."
            (#t
             ;; We found a working URL, so stop right away.
             '())
+           (#f
+            ;; Unsupported URL or other error, skip.
+            (loop rest '()))
            ((? lint-warning? warning)
             (loop rest (cons warning warnings))))))))
 
-- 
2.20.1

Marius Bakke wrote on 30 Jul 2020 00:01

Recipients:(name . Lars-Dominik Braun)(address . ldb@leibniz-psychology.org)(address . 42306@debbugs.gnu.org)

Message-ID:87k0ymq8uf.fsf@gnu.org

Lars-Dominik Braun <ldb@leibniz-psychology.org> writes:

Toggle quote (9 lines)

> Hey Marius,

>> Sorry for the late reply...

> no problem.

>> The patch mostly LGTM, but no longer applies. Can you rebase it on

>> current master? Meanwhile, a few comments:

> Sure, see attached patch, which (hopefully) also improves the description.

Thanks! FYI I had to convert the patch from ISO-8859-1 encoding to

UTF-8 in order to make it apply.

Applied with the following changes:

Toggle diff (34 lines)diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scm
index 128afc52c2..a6409765ff 100644
--- a/gnu/packages/acl.scm
+++ b/gnu/packages/acl.scm
@@ -27,7 +27,6 @@
   #:use-module (gnu packages attr)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
-  #:use-module (gnu packages bash)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages perl)
   #:use-module (guix packages)
@@ -116,14 +115,13 @@
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'fix-bin-sh
-           (lambda* (#:key inputs native-inputs #:allow-other-keys)
+           (lambda _
              (substitute* "include/buildmacros"
-               (("/bin/sh") (string-append (assoc-ref inputs "bash-minimal") "/bin/sh")))
+               (("/bin/sh") (which "sh")))
              #t)))))
     (native-inputs
      `(("automake" ,automake)
        ("autoconf" ,autoconf)
-       ("bash-minimal" ,bash-minimal)
        ("libtool" ,libtool)))
     (inputs
      `(("attr" ,attr)))
@@ -134,4 +132,3 @@
 POSIX equivalents @command{getfacl} and @command{setfacl}.  They fetch and
 manipulate access control lists for files and directories on NFSv4 mounts.")
     (license bsd-3)))
-

...however I also decided to move it to (gnu packages nfs).

Toggle quote (4 lines)

> I noticed linting fails with a pattern matching error, because git:// protocol

> URI’s are not supported. The second patch fixes it, but I’m not sure that’s a

> “proper” solution.

Me neither and I don't feel like jumping on that one right away. :-)

It seems we already have a number of git:// URLs around so it would be

good to fix it, can you submit the second patch to a separate issue?

Thanks!

Lars-Dominik Braun wrote on 30 Jul 2020 09:17

Recipients:(name . Marius Bakke)(address . marius@gnu.org)(address . 42306@debbugs.gnu.org)

Message-ID:20200730071738.GB3210@zpidnp36

Hey,

Toggle quote (2 lines)

> Thanks! FYI I had to convert the patch from ISO-8859-1 encoding to

> UTF-8 in order to make it apply.

hm, that’s weird, it worked for me.

Toggle quote (2 lines)

> It seems we already have a number of git:// URLs around so it would be

> good to fix it, can you submit the second patch to a separate issue?

Done, see bug#42615

Thank you,

Lars

Michael Rohleder wrote on 9 Sep 2020 16:11

control message for bug #42306

Recipients:(address . control@debbugs.gnu.org)

Message-ID:87tuw7jb0g.fsf@rohleder.de

tags 42306 fixed
close 42306 
quit

Your comment

This issue is archived.

To comment on this conversation send an email to 42306@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 42306

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date