mailutils: fix TODO note and build with mariadb sql

  • Done
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • ng0
Owner
unassigned
Submitted by
ng0
Severity
normal
N
N
ng0 wrote on 19 Mar 2018 21:50
(address . guix-patches@gnu.org)
20180319205014.xpdwnfop6etcappz@abyayala
Attachment: file
From 17faf5fd559ea7a6cd791f554685c36323d4e429 Mon Sep 17 00:00:00 2001
From: ng0 <ng0@n0.is>
Date: Mon, 19 Mar 2018 20:41:48 +0000
Subject: [PATCH] gnu: mailutils: configure with mysql.

* gnu/packages/mail.scm (mailutils)[arguments]: Add '--with-mysql' to configure-flags.
[inputs]: Add 'mariadb'.
---
gnu/packages/mail.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)
diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 1d52b3592..f3eb2bbd8 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -189,8 +189,7 @@
(getcwd))))
#t)))
- ;; TODO: Add `--with-sql'.
- #:configure-flags '("--sysconfdir=/etc")
+ #:configure-flags '("--sysconfdir=/etc" "--with-mysql")
#:parallel-tests? #f))
(native-inputs
;; Note: Bison and Flex needed due to
@@ -204,6 +203,7 @@
("texinfo" ,texinfo)
("guile" ,guile-2.0)
("gnutls" ,gnutls)
+ ("mariadb" ,mariadb)
("ncurses" ,ncurses)
("readline" ,readline)
("linux-pam" ,linux-pam)
--
2.16.2
L
L
Ludovic Courtès wrote on 22 Mar 2018 12:42
(name . ng0)(address . ng0@n0.is)(address . 30864@debbugs.gnu.org)
871sgcibfy.fsf@inria.fr
Hello,

ng0 <ng0@n0.is> skribis:

Toggle quote (8 lines)
> mailutils had this note to build it with sql.
>
> I picked mariadb, the attached patch builds alright.
>
> But:
> Why do we want this? mariadb adds *very much* to the size of the package and its
> dependencies.

[...]

Toggle quote (2 lines)
> total: 158.8 MiB

[...]

Toggle quote (2 lines)
> total: 695.8 MiB

That’s multiplied by 4.5, so I’d rather not do it, especially since it
doesn’t contribute to a core functionality of Mailutils AFAIK.

That said, the main problem here is the size of mariadb (and mysql),
which take 200–300 MiB alone (not the closure). We can revisit this
issue when we’ve made them smaller.

How does that sound?

Ludo’.
N
N
ng0 wrote on 22 Mar 2018 13:01
(name . Ludovic Courtès)(address . ludo@gnu.org)
20180322120140.kai2m3y5qnuludpl@abyayala
Ludovic Courtès transcribed 700 bytes:
Toggle quote (23 lines)
> Hello,
>
> ng0 <ng0@n0.is> skribis:
>
> > mailutils had this note to build it with sql.
> >
> > I picked mariadb, the attached patch builds alright.
> >
> > But:
> > Why do we want this? mariadb adds *very much* to the size of the package and its
> > dependencies.
>
> [...]
>
> > total: 158.8 MiB
>
> [...]
>
> > total: 695.8 MiB
>
> That’s multiplied by 4.5, so I’d rather not do it, especially since it
> doesn’t contribute to a core functionality of Mailutils AFAIK.

Yep, it's not very good.

Toggle quote (8 lines)
> That said, the main problem here is the size of mariadb (and mysql),
> which take 200–300 MiB alone (not the closure). We can revisit this
> issue when we’ve made them smaller.
>
> How does that sound?
>
> Ludo’.

It's okay with me.
Do you think we should close this bug for now?
--
A88C8ADD129828D7EAC02E52E22F9BBFEE348588
L
L
Ludovic Courtès wrote on 22 Mar 2018 16:51
(name . ng0)(address . ng0@n0.is)(address . 30864@debbugs.gnu.org)
87lgekglc5.fsf@gnu.org
ng0 <ng0@n0.is> skribis:

Toggle quote (2 lines)
> Ludovic Courtès transcribed 700 bytes:

[...]

Toggle quote (11 lines)
>> That said, the main problem here is the size of mariadb (and mysql),
>> which take 200–300 MiB alone (not the closure). We can revisit this
>> issue when we’ve made them smaller.
>>
>> How does that sound?
>>
>> Ludo’.
>
> It's okay with me.
> Do you think we should close this bug for now?

Yes, done!

Ludo’.
L
L
Ludovic Courtès wrote on 22 Mar 2018 16:51
control message for bug #30864
(address . control@debbugs.gnu.org)
87k1u4glbx.fsf@gnu.org
tags 30864 wontfix
close 30864
?
Your comment

This issue is archived.

To comment on this conversation send an email to 30864@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 30864
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch